fix: Table Bug Fixes (#234)

* Make x and y values for isScrollable prop optional. * fix: prevent scrolling in loading state; make x and y scroll props optional. * Set 100% height on Table's container only if scrolling on the Y is enabled.
palmetto · Sep 14, 2020 · 15e9ca7 · 15e9ca7
1 parent 922993c
commit 15e9ca7
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/components/Table/Table.module.scss b/src/components/Table/Table.module.scss
@@ -1,7 +1,5 @@
 .container {
   position: relative;
-  width: 100%;
-  height: 100%;
 
   .loading-mask {
     display: flex;
@@ -54,4 +52,8 @@
       }
     }
   }
+
+  &.full-height {
+    height: 100%;
+  }
 }
diff --git a/src/components/Table/Table.tsx b/src/components/Table/Table.tsx
@@ -104,6 +104,13 @@ const Table: FC<TableProps> = ({
   useFixedTableLayout = false,
   truncateOverflow = false,
 }) => {
+  const containerClasses = classNames(
+    styles.container,
+    {
+      [styles['full-height']]: !!isScrollable?.y,
+    },
+  );
+
   const scrollContainerClasses = classNames(
     styles['scroll-container'],
     {
@@ -125,7 +132,7 @@ const Table: FC<TableProps> = ({
   );
 
   return (
-    <div className={styles.container}>
+    <div className={containerClasses}>
       {isLoading && (
         <div className={styles['loading-mask']}>
           <Spinner size="xl" />