Skip to content

Commit

Permalink
fix: missing interface registrations (#322)
Browse files Browse the repository at this point in the history
We have a gravity batch stuck that is being relayed over and over again every 10000 blocks. Pigeon actually see the event on the target chain, but fail to inform Paloma because the gravity messages hadn't been registered against the sdk.Msg interface.

This was most likely just forgotten in the bulk of work for gravity. What bothers me is that this happened before with the AddStatusUpdate message, and apparently for some nodes this works just fine, while for others it doesn't and leads to a crash. Definitely needs more understanding. Either the type is registered or it isn't, and if it isn't, it should fail deterministically across all nodes. But it doesn't.

Tested in private test net, this resolves the issue and Pigeon successfully reports the batch as relayed. With this change, we can create a new Pigeon release. Once the majority of validators upgrade, the batch should be removed successfully.
  • Loading branch information
byte-bandit authored Nov 2, 2023
1 parent 4a5ac60 commit 5edc99b
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"github.com/cosmos/gogoproto/proto"
consensustypes "github.com/palomachain/paloma/x/consensus/types"
evmtypes "github.com/palomachain/paloma/x/evm/types"
gravitytypes "github.com/palomachain/paloma/x/gravity/types"
palomatypes "github.com/palomachain/paloma/x/paloma/types"
valsettypes "github.com/palomachain/paloma/x/valset/types"
"github.com/palomachain/pigeon/chain"
Expand Down Expand Up @@ -176,6 +177,12 @@ func palomaLensClientConfig(palomaConfig config.Paloma) *lens.ChainClientConfig
&consensustypes.MsgSetPublicAccessData{},
&consensustypes.MsgSetErrorData{},
&palomatypes.MsgAddStatusUpdate{},
&gravitytypes.MsgSendToEth{},
&gravitytypes.MsgConfirmBatch{},
&gravitytypes.MsgSendToPalomaClaim{},
&gravitytypes.MsgBatchSendToEthClaim{},
&gravitytypes.MsgCancelSendToEth{},
&gravitytypes.MsgSubmitBadSignatureEvidence{},
},
},
{
Expand All @@ -194,7 +201,7 @@ func palomaLensClientConfig(palomaConfig config.Paloma) *lens.ChainClientConfig
{
Iface: (*consensustypes.ConsensusMsg)(nil),
Msgs: []proto.Message{
&evmtypes.SubmitLogicCall{}, // TODO : Test to ensure this is right
&evmtypes.SubmitLogicCall{},
&evmtypes.Message{},
&evmtypes.ValidatorBalancesAttestation{},
&evmtypes.ValidatorBalancesAttestationRes{},
Expand Down

0 comments on commit 5edc99b

Please sign in to comment.