feat: process lightnode sale events #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this go into |
I think we should merge the current (after this PR) We can leave this PR into dev16 so it's easier to read, then merge everything to master, and push a new dev16 branch. The same we did on paloma. What do you think? |
byte-bandit
reviewed
Aug 2, 2024
maharifu
force-pushed
the
lcarvalho/feat-lightnode-sale
branch
from
ba55734 to
81ca12f
Compare
byte-bandit
approved these changes
Aug 5, 2024
Also, increase logging.
byte-bandit
approved these changes
Aug 6, 2024
maharifu
added a commit
that referenced
this pull request
Aug 6, 2024
* chore: rename eth messages (#412) * feat: process lightnode sale events (#414) * chore: update paloma deps to local development * feat: read node sale events from compass * chore: add unified skyway events handler * feat: use unified skyway event handler * chore: remove left pad on paloma address * fix: wrong NodeSaleEvent hash Also, increase logging. * chore: update REAME to point to 1.12.4 --------- Co-authored-by: Christian Lohr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github tickets
Background
We need pigeon to pick up on node sale events and report them to paloma. These events will come from compass, following the implementation in palomachain/compass-evm#38. This PR adds support to read and relay those events.
Note: This uses
dev16branch as base since it builds on top of the renamed skyway calls.Testing completed
Breaking changes