feat: add compass ID to all turnstone messages #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byte-bandit
approved these changes
Aug 9, 2024
byte-bandit
added a commit
that referenced
this pull request
Aug 16, 2024
* feat: gas estimation changes (#419) * feat: gas estimation loops * chore: remove unused test * feat: estimate messages before sending * feat: submit_batch estimation * fix: linting * Update chain/evm/client.go Co-authored-by: Luis Carvalho <[email protected]> * Update chain/evm/compass.go Co-authored-by: Luis Carvalho <[email protected]> * Update chain/evm/compass.go Co-authored-by: Luis Carvalho <[email protected]> * Update chain/evm/compass.go Co-authored-by: Luis Carvalho <[email protected]> * Update chain/paloma/skyway.go Co-authored-by: Luis Carvalho <[email protected]> * fix: linting --------- Co-authored-by: Luis Carvalho <[email protected]> * feat: add compass ID to all turnstone messages (#420) * fix: use somewhat realistic dummy gas estimate (#421) * chore: refactor paloma address to bytes32 (#422) * Clohr/pf fixes (#424) * fix: pass estimate only flag when needed * fix: estimation on ARB * fix: send eth address for relayer * fix: register gas estimation message * fix: avoid panic in update_valset * chore: update valset_update keccak256 * chore: ignore messages we fail to estimate * chore: do not return errors from estimation * fix: register msg type * chore: fix typo * chore: update palomachain/paloma dependency --------- Co-authored-by: Luis Carvalho <[email protected]> --------- Co-authored-by: Luis Carvalho <[email protected]> Co-authored-by: Luis Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github tickets
Background
Skyway needs to know the compass ID that generated the turnstone messages, this PR adds it to all messages.
Replaces #417
Testing completed
Breaking changes