Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker / Podman Image build added #8

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

sips4711
Copy link

Allows to build a container image. Container Image could be used in pipelines when specifying the params "-e channel=stable -e depth=2"

example build: podman run --rm -it -v $(pwd):/documents -e channel=stable -e depth=2 localhost/ocp4upc ocp4upc.sh 4.2.36-4.7

@pamoedom
Copy link
Owner

Hi Sebastian, thanks for this contribution, much appreciated.

However, there are some things to review:

  1. The podman run example should contemplate also SELinux permissions, I think it would be better to put it in the following manner:
$ podman build -t localhost/ocp4upc .
$ podman run --rm -it -v $(pwd):/documents:z -e channel=stable -e depth=2 localhost/ocp4upc ocp4upc.sh 4.2.36-4.7
  1. I've tried the script on this manner and the generated graph is not correct, maybe some package version in the alpine distro is different, I'll need to further investigate on this before merging your changes, example:

[From the podman run with alpine]
stable-multigraph_4 2 36-4 7_amd64_20210330

[From local]
stable-multigraph_4 2 36-4 7_amd64_20210330

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants