feat: amm trade add shadow request 1% #10931
Conversation
chef-ryan
requested review from
ChefMomota,
Chef-Yogi,
chefjackson,
ChefJerry,
thechefpenguin and
chef-eric
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
chef-ryan
changed the title
chef-ryan
force-pushed
the
feat/amm-trade-shadow-request
branch
from
65587c4
to
3ff07d3
Compare
| export const QUOTING_API_PREFIX_ORIGINAL = 'https://pcsx-order-price-api-test-master-viosr.ondigitalocean.app' | ||
|
|
||
| export const QUOTING_API_PREFIX_OPTIMIZED = 'https://pcsx-order-price-api-test-branch-nfu7y.ondigitalocean.app' |
There was a problem hiding this comment.
not necessarily to put them in constants as they're mainly for testing purpose
| useBestTradeFromApiShadow(bestTradeOptions, 'quote-api-ori') | ||
| useBestTradeFromApiShadow(bestTradeOptions, 'quote-api-opt') |
There was a problem hiding this comment.
let's enable for all chains. Previously the api is only enabled on arb and eth
| export function useTradeApiPrefetchShadow( | ||
| { currencyA, currencyB, poolTypes, enabled = true }: PrefetchParams, | ||
| prefix: string, | ||
| queryType: string, | ||
| ) { | ||
| return useQuery({ | ||
| enabled: !!(currencyA && currencyB && poolTypes?.length && enabled), | ||
| queryKey: [`${queryType}-prefetch`, currencyA?.chainId, currencyA?.symbol, currencyB?.symbol, poolTypes] as const, | ||
| queryFn: async ({ signal }) => { | ||
| if (!currencyA || !currencyB || !poolTypes?.length) { | ||
| throw new Error('Invalid prefetch params') | ||
| } | ||
|
|
||
| const serverRes = await fetch( | ||
| `${prefix}/_pools/${currencyA.chainId}/${getCurrencyIdentifierForApi(currencyA)}/${getCurrencyIdentifierForApi( | ||
| currencyB, | ||
| )}?${qs.stringify({ protocols: poolTypes.map(getPoolTypeKey) })}`, | ||
| { | ||
| method: 'GET', | ||
| signal, | ||
| }, | ||
| ) | ||
| const res = await serverRes.json() | ||
| if (!res.success) { | ||
| throw new Error(res.message) | ||
| } | ||
| return res | ||
| }, | ||
| staleTime: currencyA?.chainId ? POOLS_FAST_REVALIDATE[currencyA.chainId] : 0, | ||
| refetchInterval: currencyA?.chainId ? POOLS_FAST_REVALIDATE[currencyA.chainId] : 0, | ||
| }) | ||
| } |
There was a problem hiding this comment.
we don't need a new hook. Let's reuse useTradeApiPrefetch
There was a problem hiding this comment.
cuz it's not used right now
| useEffect(() => { | ||
| if (featureFlag && !!(amount && currency)) { | ||
| poolPreFetch.refetch() | ||
| } | ||
| }, [amount?.currency, currency]) |
There was a problem hiding this comment.
we don't need refetch for prefetch
PR-Codex overview
This PR introduces a new experimental feature for optimized AMM trading, updates hooks for trade fetching, and enhances trade API interactions with shadow querying.
Detailed summary
OPTIMIZED_AMM_TRADEtoEXPERIMENTAL_FEATURES.useBestTradeFromApiShadowfor optimized AMM trade fetching.useSwapBestOrderto utilizeuseBestTradeFromApiShadow.useTradeApiPrefetchto acceptprefixandqueryTypeparameters.