fix: List cache with different keys returns same result #10939
+22
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memoyil
requested review from
ChefMomota,
Chef-Yogi,
chefjackson,
ChefJerry,
thechefpenguin,
chef-eric and
chef-ryan
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
|
memoyil
force-pushed
the
feature/fix_list_cache_with_different_keys
branch
2 times, most recently
from
67f1c2e
to
69e99eb
Compare
memoyil
commented
Nov 13, 2024
| @@ -79,13 +79,16 @@ const combineTokenMaps = (lists: ListsState['byUrl'], urls: string[]): any => { | |||
| const current = lists[currentUrl]?.current | |||
| if (!current) return allTokens | |||
| try { | |||
| const newTokens = Object.assign(listToTokenMap(current, 'address')) | |||
| return combineMaps(allTokens, newTokens) | |||
There was a problem hiding this comment.
no need to create a new object on each iteration
memoyil
commented
Nov 13, 2024
| @@ -79,13 +79,16 @@ const combineTokenMaps = (lists: ListsState['byUrl'], urls: string[]): any => { | |||
| const current = lists[currentUrl]?.current | |||
| if (!current) return allTokens | |||
| try { | |||
| const newTokens = Object.assign(listToTokenMap(current, 'address')) | |||
There was a problem hiding this comment.
no need shallow copy
memoyil
force-pushed
the
feature/fix_list_cache_with_different_keys
branch
from
69e99eb
to
4f2e591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on enhancing the type safety and immutability of token-related data structures in the
@pancakeswap/tokenspackage by exporting thecreateEmptyListfunction and updating the return types ofEMPTY_LISTandcreateEmptyList.Detailed summary
createEmptyListfrom a private to an exported function.createEmptyListto return aReadonly<TokenAddressMap<ChainId>>.EMPTY_LISTto be of typeReadonly<TokenAddressMap<ChainId>>.combineTokenMapsto check forurls?.length.newTokensincombineTokenMapsfor improved clarity.listCacheto store aMap<string, TokenAddressMap>instead ofTokenAddressMap.listToTokenMapto require akeyparameter and adjusted its logic to handle the newlistCachestructure.