fix: 🐛 Fix infinit refresh bugs #10943
Conversation
chef-ryan
requested review from
ChefMomota,
Chef-Yogi,
chefjackson,
ChefJerry,
thechefpenguin and
chef-eric
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
| @@ -62,7 +62,7 @@ const useSelectRowsWithQuery = (gauges: Gauge[] | undefined) => { | |||
| const urlHashes = queryHashes.filter((hash) => !newHashes.includes(hash)) | |||
| setSelectRowsHash(urlHashes.concat(newHashes)) | |||
| } | |||
| }, [isLoading, prevVotedGauges, queryHashes]) | |||
| }, [isLoading, prevVotedGauges.map((x) => x.hash).join('-'), queryHashes]) | |||
There was a problem hiding this comment.
will map every render, how about to use a memo value
| @@ -62,7 +62,7 @@ const useSelectRowsWithQuery = (gauges: Gauge[] | undefined) => { | |||
| const urlHashes = queryHashes.filter((hash) => !newHashes.includes(hash)) | |||
| setSelectRowsHash(urlHashes.concat(newHashes)) | |||
| } | |||
| }, [isLoading, prevVotedGauges, queryHashes]) | |||
| }, [isLoading, prevVotedGauges.map((x) => x.hash).join('-'), queryHashes]) | |||
There was a problem hiding this comment.
would suggest to fix the ref issue within the useUserVoteGauges hook
There was a problem hiding this comment.
@chefjackson
Do you mean something like this?
const prevGaugesRef = useRef(prevVotedGauges);
const hasChanges = prevGaugesRef.current.some(
(prevGauge, index) => prevGauge.hash !== prevVotedGauges[index]?.hash
);
apps/web/src/views/GaugesVoting/components/Table/VoteTable/hooks/useGaugeRows.ts
Outdated
Show resolved
Hide resolved
chef-ryan
dismissed stale reviews from Chef-Yogi and chefjackson
via
8be59a3
| @@ -35,7 +35,7 @@ export const useUserVoteSlopes = () => { | |||
| userInfo?.cakePoolProxy, | |||
| publicClient, | |||
| ], | |||
|
|
|||
| initialData: [], | |||
There was a problem hiding this comment.
if initial data used isLoading will be false always even there is no real fetch, so i would suggest to memoize the data when returning
There was a problem hiding this comment.
placeholderData behaves the same if i am not mistaken
There was a problem hiding this comment.
Hi, I checked, momoyil correct.
Since set either initialData or placeholderData will suggest isloading to be false.
Let's assume this is actually what should be the standard behavior.
Introduct a memod state is too complex for this easy requirement.
So I perfer to do no changes here.
Let's migrate to async atom in future.
PR-Codex overview
This PR modifies the
useUserVoteGaugeshook in theapps/web/src/views/GaugesVoting/hooks/useUserVoteGauges.tsfile, focusing on the handling of thepublicClientand the structure of the returned data.Detailed summary
publicClientto its original form.initialDataproperty in the query options to an empty array.datainstead of using a fallback to an empty array.