fix: undefined gauge hash #10948
Merged
fix: undefined gauge hash #10948
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefJerry
requested review from
ChefMomota,
Chef-Yogi,
chefjackson,
thechefpenguin,
chef-eric and
chef-ryan
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
chefjackson
approved these changes
Nov 16, 2024
chef-ryan
approved these changes
Nov 16, 2024
ChefMomota
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on improving the filtering of
gaugesin theuseUserVoteGaugeshook to ensure only valid gauges with ahashare processed when creating thecontractsarray.Detailed summary
.filter((g) => !!g.hash)to ensure only gauges with a validhashare included.contractsarray creation remains the same, but now excludes any invalid gauges.