Skip to content

add overload for itertuples with name None, resolves #854 #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

mutricyl
Copy link
Contributor

) -> Iterable[_PandasNamedTuple]: ...
@overload
def itertuples(
self, name: None, index: _bool = ...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self, name: None, index: _bool = ...
index: _bool = ..., name: None = None)

You have to allow for the positional arguments.

@mutricyl mutricyl requested a review from Dr-Irv April 29, 2024 17:05
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mutricyl

@Dr-Irv Dr-Irv merged commit 638397f into pandas-dev:main Apr 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

itertuples doesn't respect name parameter
2 participants