Bug Fix: #60343 Construction of Series / Index fails from dict keys when "str" dtype is specified explicitly - PR 2 #60436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pyarrow]" while PyArrow is not installed (pandas-dev#60413) * Add test * Fix * Add note * Update pandas/tests/dtypes/test_common.py Co-authored-by: Matthew Roeschke <[email protected]> * update * Fix doc warning --------- Co-authored-by: Matthew Roeschke <[email protected]>
|
@jorisvandenbossche Can you check now please and if possible merge? I considered your comments in this updated PR and added the generic if. Now besides the dict.keys(), it will handle other iterable such as dict.values() and addressing other similar types. My IDE is throwing some unintentional formatting issues which I can't seem to undo, but in this commit, I only changed the if condition in the construction.py and nothing else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior (pd.Index(d.keys())) worked correctly, but explicitly setting dtype="str" raised a ValueError. The issue stemmed from dict_keys not being converted to a proper array-like structure before being passed to StringDtype, which couldn't handle such inputs.
To fix the issue:
-Handles Existing Test Cases and fixes previous PR fix issues.
After the fix both the default (pd.Index(d.keys())) and explicit (pd.Index(d.keys(), dtype="str")) cases work: