-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CI: Fix test failures in 32-bit environment #61423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Fix test failures in 32-bit environment #61423
Conversation
@mroeschke Hi, this error seems to be an upstream issue. I created this MR just to evaluate whether it's caused by Cython. |
Thanks for starting investigation. If this is caused by Cython then we probably need to pin it like you did. If you could create a minimal example for the Cython folks (that doesn't use pandas), that'd be appreciated |
@@ -246,7 +246,7 @@ jobs: | |||
. ~/virtualenvs/pandas-dev/bin/activate | |||
python -m pip install --no-cache-dir -U pip wheel setuptools meson[ninja]==1.2.1 meson-python==0.13.1 | |||
python -m pip install numpy -Csetup-args="-Dallow-noblas=true" | |||
python -m pip install --no-cache-dir versioneer[toml] cython python-dateutil pytest>=7.3.2 pytest-xdist>=3.4.0 hypothesis>=6.84.0 | |||
python -m pip install --no-cache-dir versioneer[toml] cython==3.0.10 python-dateutil pytest>=7.3.2 pytest-xdist>=3.4.0 hypothesis>=6.84.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment somewhere here about why we're pinning Cython? The we can take this out of draft and merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I've added the comment in 378ae75.
Thanks @chilin0525 |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Co-authored-by: ChiLin Chiu <[email protected]>
I noticed that some CI failures are due to the same test errors appearing in several recent PRs.
After comparing multiple failed and successful CI runs, it seems that the unit tests fail when using
cython==3.1.0
in the Linux 32-bit environment.cython==3.0.10
:cython==3.1.0
: