-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: Fix DataFrame constructor misclassification of array-like with 'name' attribute (#61443) #61451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…name' attribute Previously, any object with a .name attribute (like some vtkArray-like objects) was assumed to be a Series or Index, causing the constructor to misinterpret the input. This fix ensures we only apply the named-Index/Series logic when the input is actually an instance of ABCSeries or ABCIndex *and* has a non-None name. Closes pandas-dev#61443.
Note: One unrelated pre-commit check failed:
One of the flagged lines includes: f" instead.", This has a space at the start of the string rather than the end of the previous one, which violates the Since this file wasn't touched in this PR and is unrelated to the fix, I’ve left it as-is. Let me know if you'd like me to patch it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Can you add a line in the whatsnew for 3.0 under the Other
section in bugfixes.
One unrelated pre-commit check failed
As this isn't happening on the CI, I don't think it's of concern.
Thanks for the review @rhshadrach! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @iabhi4 |
BUG: Fix DataFrame constructor misclassification of array-like with 'name' attribute
Previously, any object with a
.name
attribute (like somevtkArray
-like objects) was assumed to be aSeries
orIndex
, causing the DataFrame constructor to misinterpret the input and raise errors when passed valid 2D array-likes.This fix ensures we only apply the named-Series/Index logic when the input is actually an instance of
ABCSeries
orABCIndex
, and thename
is notNone
.A new test was added to ensure array-like subclasses with
.name
are handled correctly.DataFrame
constructor not compatible with array-like classes that have a'name'
attribute #61443pre-commit
.name
casedoc/source/whatsnew/v3.0.0.rst