-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: DataFrame.explode fails with str dtype #61623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'd personally have the new release notes template added in a separate issue, but no big deal.
Btw, did we have problems before to have the result is not df
assert? I haven't used it before, it'd be good to understand in which tests it make sense. Thanks!
I think it makes sense to check this when we have a no-op that should return a copy. If the operation modifies the data (which is the case for the vast majority of tests), I don't think it needs to be checked. |
@datapythonista - fixed up the docs build, this should be ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Backport -> #61699 |
…#61699) BUG: DataFrame.explode fails with str dtype (#61623) Co-authored-by: Richard Shadrach <[email protected]>
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.This operation works on all other dtypes, e.g.