Skip to content

BUG: Fix assert_series_equal for categoricals with nulls and check_category_order=False (#62008) #62011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
fc4f736
BUG : Fix Series.str.contains with compiled regex on Arrow string
Aniketsy Jul 25, 2025
bc2fd6e
BUG: Fix handling of compiled regex in Series.str.contains for Arrow-…
Aniketsy Jul 25, 2025
2fbf085
BUG: Fix handling of compiled regex in Series.str.contains for Arrow-…
Aniketsy Jul 25, 2025
9e085fa
STYLE: Fix formatting and docstring issues in str.contains
Aniketsy Jul 25, 2025
9f3b34f
Fixed ruff format
Aniketsy Jul 25, 2025
f618751
Move fix into _str_contains of ArrowExtensionArray
Aniketsy Jul 26, 2025
47c0826
Move fix into _str_contains of ArrowExtensionArray
Aniketsy Jul 26, 2025
5bdb2a6
Revert changes to pandas/core/strings/accessor.py from PR #61946
Aniketsy Jul 26, 2025
7293f65
Move fix into _str_contains of ArrowExtensionArray
Aniketsy Jul 26, 2025
49b974c
Move fix into _str_contains of ArrowExtensionArray
Aniketsy Jul 26, 2025
2c5c194
BUG: Fix Series.str.contains with compiled regex and arrow strings (#…
Aniketsy Jul 28, 2025
f6277b7
Revert changes to pandas/core/arrays/arrow/array.py in PR
Aniketsy Jul 28, 2025
9297460
BUG: Fix Series.str.contains with compiled regex on Arrow string dtyp…
Aniketsy Jul 28, 2025
967f462
BUG: Fix Series.str.contains with compiled regex on Arrow string dtyp…
Aniketsy Jul 28, 2025
314a7ab
BUG: Fix Series.str.contains with compiled regex on Arrow string dtyp…
Aniketsy Jul 29, 2025
dceb786
BUG: Fix Series.str.contains with compiled regex on Arrow string dtyp…
Aniketsy Jul 29, 2025
f6ba439
Revert changes to test_strings.py
Aniketsy Jul 29, 2025
ce7cf22
BUG: Fix Series.str.contains with compiled regex on Arrow string dtyp…
Aniketsy Jul 29, 2025
65f9b60
BUG: Fix Series.str.contains with compiled regex on Arrow string dtyp…
Aniketsy Jul 29, 2025
415bd87
BUG: Fix Series.str.contains with compiled regex on Arrow string dtyp…
Aniketsy Jul 29, 2025
5a94001
BUG: Fix Series.str.contains with compiled regex on Arrow string dtyp…
Aniketsy Jul 29, 2025
ba3f3cf
Revert test_strings.py changes and remove accidental whatsnew file
Aniketsy Jul 29, 2025
790145c
Revert test_strings.py changes and remove accidental whatsnew file
Aniketsy Jul 29, 2025
836cc4f
BUG: Fix Series.str.contains with compiled regex on Arrow string dtyp…
Aniketsy Jul 30, 2025
781e381
BUG: Fix Series.str.contains with compiled regex on Arrow string dtyp…
Aniketsy Jul 30, 2025
09c84e4
BUG: Implement elementwise IntervalArray.overlaps (#62004)
Aniketsy Jul 30, 2025
530c141
BUG: Fix assert_series_equal for categoricals with nulls and check_ca…
Aniketsy Jul 31, 2025
bb2817e
Revert unintended changes to interval.py
Aniketsy Jul 31, 2025
f28994d
Remove unintended changes to test_interval.py
Aniketsy Jul 31, 2025
1b70b3a
BUG: Fix assert_series_equal for categoricals with nulls and check_ca…
Aniketsy Jul 31, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions doc/source/whatsnew/v2.3.2.rst

This file was deleted.

11 changes: 9 additions & 2 deletions pandas/_testing/asserters.py
Original file line number Diff line number Diff line change
Expand Up @@ -495,8 +495,15 @@ def assert_categorical_equal(
lc, rc = left.categories, right.categories
assert_index_equal(lc, rc, obj=f"{obj}.categories", exact=exact)
assert_index_equal(
left.categories.take(left.codes),
right.categories.take(right.codes),
Index(
[left.categories[code] if code >= 0 else np.nan for code in left.codes]
),
Index(
[
right.categories[code] if code >= 0 else np.nan
for code in right.codes
]
),
obj=f"{obj}.values",
exact=exact,
)
Expand Down
1 change: 0 additions & 1 deletion pandas/tests/strings/test_strings.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import pytest

from pandas import (
NA,
DataFrame,
Index,
MultiIndex,
Expand Down
13 changes: 13 additions & 0 deletions pandas/tests/util/test_assert_categorical_equal.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import numpy as np
import pytest

from pandas import Categorical
Expand Down Expand Up @@ -86,3 +87,15 @@ def test_categorical_equal_object_override(obj):

with pytest.raises(AssertionError, match=msg):
tm.assert_categorical_equal(c1, c2, obj=obj)


def test_categorical_equal_with_nans_and_different_order():
# GH#62008
values = ["B", np.nan, "D"]
categories_left = ["B", "D"]
categories_right = categories_left[::-1]

left = Categorical(values, categories=categories_left)
right = Categorical(values, categories=categories_right)

tm.assert_categorical_equal(left, right, check_category_order=False)
Loading