Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gravel-stonebrick #33

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

add gravel-stonebrick #33

wants to merge 3 commits into from

Conversation

BuckarooBanzay
Copy link
Contributor

@BuckarooBanzay BuckarooBanzay commented Feb 13, 2021

This PR adds a half-gravel, half-stonebrick node with support for the table-saw

@wsor4035

could we get a node that is gravel on top and a solid base on bottem like linux forks has? also, ability to slice it into 3 piece slopes to match the track slope
https://git.bananach.space/moreblocks.git/tree/nodes.lua#n634

screenshot_20210213_114027

TODO

  • recipe for moreblocks:gravel_stonebrick

Stats

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Feb 13, 2021
@OgelGames
Copy link
Contributor

recipe for moreblocks:gravel_stonebrick

minetest.register_craft({
	output = "moreblocks:gravel_stonebrick 4",
	recipe = {
		{"default:gravel", "default:gravel"},
		{"default:stonebrick", "default:stonebrick"},
	}
})

Copy link
Contributor

@OgelGames OgelGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works 👍

@wsor4035
Copy link

see comments in the pandora box discord

@S-S-X
Copy link
Member

S-S-X commented Apr 3, 2021

Tested, works 👍

Did you test if these block trains on slopes? I think there's some group or property to not block trains...

@OgelGames
Copy link
Contributor

Did you test if these block trains on slopes? I think there's some group or property to not block trains...

No, but I don't think they would, and if there's any issues it can easily be added later.

@S-S-X
Copy link
Member

S-S-X commented Apr 4, 2021

Did you test if these block trains on slopes? I think there's some group or property to not block trains...

No, but I don't think they would, and if there's any issues it can easily be added later.

I had exact opposite expectation: I think they would, reason for asking for test. So tested and these gravel slopes will block trains in slopes just like all other slopes.

edit. checked what was needed and it is group not_blocking_trains

Could be added directly to full node, tested that. However only some of these nodes actually should be non blocking, not all.
Maybe stairplus has something in API for this?

@OgelGames
Copy link
Contributor

OgelGames commented Apr 4, 2021

gravel slopes will block trains in slopes just like all other slopes

Ah, I thought the other slopes didn't block trains...

Probably the easiest way would be to override stairsplus:prepare_groups and add the extra group in there.
https://github.com/minetest-mods/moreblocks/blob/master/stairsplus/init.lua#L24

EDIT: actually that might not be possible because of mod load order... 🤔

@Montandalar
Copy link

Montandalar commented Dec 15, 2021

LinuxForks' moreblocks has a set of gravel train helper blocks that they use: Gravel stonebrick, gravel slope, slope 2a, 2b, 3a, 3b and 3c. These match the texture of the slope block properly and have not_blocking_trains on them.

linuxforks_moreblocks_gravelstuff

I don't think the whole gamut of circular saw shapes is actually helpful, so I would rather just port the LinuxForks shaps over to pandorabox_custom than faff around with stairsplus/moreblocks which clearly has problems. I can prepare a PR if you want.

@S-S-X
Copy link
Member

S-S-X commented Dec 15, 2021

I don't think the whole gamut of circular saw shapes is actually helpful

I do think a lot of those would be very good, already many times and with many nodes I wanted to have this feature to allow building railways to existing areas.

At least: stone tiles, tar blocks, most scifi nodes, most tree trunks and planks and of course gravel.

edit to clarify: just group support would be good for most, not necessarily actual rail nodes.
for gravel however it would be nice to have actual rail nodes that also are walkable instead of those that completely skips collisions. (does advtrain have problem with that? why "default" gravel slopes are not walkable?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants