close offline player loophole #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like this code is a leftover from when jds didn't have digilines yet and the player was the one interacting with the formspec. Now the player is the owner of the jd. Also back then can_travel() was inspecting XP instead of privs. XP is stored in player meta, so isn't checkable when player is offline. With this change, players can't jump over warzone or other places they normally couldn't go to (except landing-priv area). They used an alt to place the JD then while the alt wasn't online, the checks were skipped and by trapping the online player in a chair(/bike/minecart/...) the teleport_back globalstep couldn't force them back to /spawn.
|
have not tested and am not particularly motivated to advance this. |
|
i'll check your other PR's in a few days btw 😏 (ping me up if there is something urgent) |
|
Nothing urgent. If you are going to prioritize, these JD related ones: (minus the unexplored area one) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like this code is a leftover from when JDs didn't have digilines yet and the
playerwas the one interacting with the formspec. Now theplayeris theownerof the JD.Also back then
can_travel()was inspecting XP instead of privs. XP is stored in player meta, so isn't checkable when player is offline.With this change, players can't jump over warzone or other places they normally couldn't go to (except landing-priv area). They used an alt to place the JD then while the alt wasn't online, the checks were skipped and by trapping the
online player in a chair(/bike/minecart/...) the
teleport_back globalstep couldn't force them
back to /spawn.