Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GHA and compile-all #7

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Fix GHA and compile-all #7

merged 3 commits into from
Dec 18, 2023

Conversation

ronaldtse
Copy link
Contributor

No description provided.

@ronaldtse
Copy link
Contributor Author

@ribose-jeffreylau could you please help fix this?

I've replaced the crypto.randomUUID call with another package but there's some dependency issue in the converters/index.ts and glossary.ts files.

Error: [common]: src/convertors/index.ts(7,36): error TS2307: Cannot find module '@lukeed/uuid/secure' or its corresponding type declarations.
...

@ribose-jeffreylau ribose-jeffreylau merged commit 92d3b0a into master Dec 18, 2023
2 checks passed
@ribose-jeffreylau ribose-jeffreylau deleted the rt-fix-compile branch December 18, 2023 09:29
@ronaldtse
Copy link
Contributor Author

@ribose-jeffreylau thanks! There is also the .yarn/cache directory pushed into the repository. Should we ignore it moving forward?

@ribose-jeffreylau
Copy link
Contributor

I think there is a trade-off. See: https://stackoverflow.com/questions/69885538/should-i-push-the-yarn-cache-folder-to-github-yarn2

On the one hand, pushing .yarn/cache increases repo size. On the other hand, it makes the project resilient to network interruptions.

To me, the latter seems to outweigh increases of repo size.

@strogonoff What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants