-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract libmmel out as a separate package #104
Draft
ribose-jeffreylau
wants to merge
63
commits into
main
Choose a base branch
from
libmmel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribose-jeffreylau
added
enhancement
New feature or request
🧹refactor
Clean up technical debt
⚙️ backend
labels
Feb 6, 2023
ribose-jeffreylau
force-pushed
the
libmmel
branch
from
February 6, 2023 09:24
55fc373
to
9a0bde9
Compare
ribose-jeffreylau
force-pushed
the
libmmel
branch
3 times, most recently
from
February 17, 2023 09:55
d116309
to
d554860
Compare
ribose-jeffreylau
force-pushed
the
libmmel
branch
from
May 12, 2023 10:38
08fbb49
to
f84af19
Compare
ribose-jeffreylau
force-pushed
the
libmmel
branch
3 times, most recently
from
May 19, 2023 06:35
0681e4c
to
b551e10
Compare
ribose-jeffreylau
force-pushed
the
libmmel
branch
from
May 19, 2023 07:04
b551e10
to
63c5018
Compare
ribose-jeffreylau
force-pushed
the
libmmel
branch
2 times, most recently
from
May 19, 2023 08:55
1514f29
to
b34b7af
Compare
ribose-jeffreylau
force-pushed
the
libmmel
branch
from
May 19, 2023 09:07
b34b7af
to
271ebc2
Compare
Commands used: ```bash cd packages while read -r file do echo file is $file path="${file##*/src}" path="${path%/*}" path="${path#/}" path="${path:-.}" echo file=$file echo path=$path sed -i -r "s|(import .*')(\..*)';|printf \"\1@/\"\; realpath --relative-to=. -m \"${path}/\2\" \| tr -d \"\n\" \; printf \"'; \"\;|ge" "$file" done < <(fd . legacy/src -t f -e ts -e tsx) while read -r file do echo file is $file path="${file##*/src}" path="${path%/*}" path="${path#/}" path="${path:-.}" echo file=$file echo path=$path sed -i -r "s|(import .*')(\..*)';|printf \"\1@/\"\; realpath --relative-to=. -m \"${path}/\2\" \| tr -d \"\n\" \; printf \"'; \"\;|ge" "$file" done < <(fd . libmmel/src -t f -e ts -e tsx) ```
Commands used: ```bash cd packages while read -r file do echo file is $file path="${file##*/src}" path="${path%/*}" path="${path#/}" path="${path:-.}" echo file=$file echo path=$path sed -i -r \ "s|(.*)(from ')(\..*)';| printf \"\1\2@/\"\; realpath --relative-to=. -m \"${path}/\3\" \| tr -d \"\n\" \; printf \"';\"\;|ge" \ "$file" done < <(fd . legacy/src -t f -e ts -e tsx) while read -r file do echo file is $file path="${file##*/src}" path="${path%/*}" path="${path#/}" path="${path:-.}" echo file=$file echo path=$path sed -i -r \ "s|(.*)(from ')(\..*)';| printf \"\1\2@/\"\; realpath --relative-to=. -m \"${path}/\3\" \| tr -d \"\n\" \; printf \"';\"\;|ge" \ "$file" done < <(fd . libmmel/src -t f -e ts -e tsx) ```
ribose-jeffreylau
force-pushed
the
libmmel
branch
from
August 16, 2023 11:35
bb3caaf
to
1bfd761
Compare
... for the case when `workflow_dispatch` is triggered.
The error in Paneron when initializing the extension was: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons: 1. You might have mismatching versions of React and the renderer (such as React DOM) 2. You might be breaking the Rules of Hooks 3. You might have more than one copy of React in the same app See for tips about how to debug and fix this problem.
... except for except for ts-node which is required by Jest to read Typescript configuration files.
... in preparation for move of libmmel to Paneron core
... so that TS 5 ("importsNotUsedAsValues") will be happy, too
... to prepare for incorporation of libmmel in Paneron core.
ribose-jeffreylau
force-pushed
the
libmmel
branch
from
August 18, 2023 08:22
a6ee46b
to
a084cf2
Compare
ribose-jeffreylau
force-pushed
the
libmmel
branch
from
August 24, 2023 13:03
ca55267
to
1437477
Compare
... in preparation for using MMEL de-/serialization from it.
... and use the provided API from extension-kit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.