Extract libmmel out as a separate package

packages/legacy/.eslintrc.js → .eslintrc.js

@@ -120,14 +120,24 @@ var rules = {
   'no-empty-function' : 'off',
   'react/prop-types' : 'off',
   'react/no-unknown-property' : ['error', { ignore : ['css'] }],
+  '@typescript-eslint/consistent-type-imports' : [
+    'error',
+    {
+      prefer: 'type-imports',
+      fixStyle: 'separate-type-imports',
+    }
+  ],
   '@typescript-eslint/no-empty-function' : 'off',
+  '@typescript-eslint/no-import-type-side-effects': 'error',
   '@typescript-eslint/no-non-null-asserted-nullish-coalescing' : 'warn',
   'no-unused-vars' : 'off',
   '@typescript-eslint/no-unused-vars' : 'warn',
   '@emotion/jsx-import' : 'error',
   '@emotion/no-vanilla' : 'error',
   '@emotion/import-from-emotion' : 'error',
   '@emotion/styled-import' : 'error',
+  'react-hooks/rules-of-hooks': 'error', // Checks rules of Hooks
+  'react-hooks/exhaustive-deps': 'warn', // Checks effect dependencies
 };
 
 module.exports = {
@@ -153,12 +163,38 @@ module.exports = {
       typescript : {}
     }
   },
-  "rules" : rules,
   overrides : [
     {
+      files : ["*.ts", "*.tsx"],
+      plugins: [
+        "react-hooks",
+      ],
+      rules : rules,
+    },
+    {
+      extends : [],
+      parser : null,
+      parserOptions : {},
+      settings : {},
       files : ["*.js"],
       rules : rules,
     },
+    {
+      "files"   : ["*.json", "*.json5", "*.jsonc"],
+      parser: "jsonc-eslint-parser",
+      parserOptions : {},
+      extends: [
+        // add more generic rulesets here, such as:
+        // 'eslint:recommended',
+        // "plugin:jsonc/recommended-with-jsonc",
+      ],
+      "rules"   : {
+        "key-spacing" : "off",
+        "max-len" : "off",
+        "quote-props" : ["error", "always"],
+        "quotes" : ["error", "double"],
+      },
+    },
     {
       "files"   : ["spec/**"],
       "plugins" : ["jest", "@emotion"],

.github/workflows/audit.yml

@@ -17,13 +17,13 @@ jobs:
       - uses: actions/setup-node@v3
         id: setup-node
         with:
-          node-version: ${{ matrix.node }}
+          node-version: 20
 
       - uses: pnpm/action-setup@v2
         name: Install pnpm
         id: pnpm-install
         with:
-          version: 7
+          version: 8
           run_install: false
 
       # See: https://github.com/pnpm/action-setup#use-cache-to-reduce-installation-time

.github/workflows/tests.yml → .github/workflows/build-and-test.yml

@@ -1,4 +1,4 @@
-name: tests
+name: build & test
 
 on:
   workflow_call:
@@ -15,7 +15,7 @@ on:
       - '**.nix'
       - 'flake.lock'
       - '.github/workflows/*.yml'
-      - '!.github/workflows/tests.yml'
+      - '!.github/workflows/build-and-test.yml'
       - '!.github/workflows/lint.yml'
       - '!.github/workflows/build.yml'
       - '!.github/workflows/test.yml'
@@ -33,9 +33,6 @@ on:
       - 'flake.lock'
   workflow_dispatch:
 
-env:
-  CACHE_DIR: installs
-
 jobs:
   lint:
     uses: ./.github/workflows/lint.yml
@@ -44,9 +41,7 @@ jobs:
     uses: ./.github/workflows/build.yml
 
   test:
-    needs: [build]
     uses: ./.github/workflows/test.yml
 
   test-e2e:
-    needs: [build]
     uses: ./.github/workflows/test-e2e.yml

.github/workflows/build.yml

@@ -5,19 +5,22 @@ on:
   workflow_dispatch:
 
 env:
-  CACHE_DIR: installs
+  CACHE_DIR: dist
   MAIN_PACKAGE_PATH: packages/legacy
 
 jobs:
   build:
     name: Build
-    runs-on: ${{ matrix.os }}
+    runs-on: ubuntu-latest
+
+    concurrency:
+      group: '${{ github.workflow }}-build-${{ matrix.node }}-${{ github.head_ref || github.ref_name }}'
+      cancel-in-progress: true
 
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, macos-latest, windows-latest]
-        node: ['14.x', '16.x', '18.x']
+        node: [16, 18, 20]
 
     steps:
       - uses: actions/checkout@v3
@@ -29,9 +32,7 @@ jobs:
         # results down the file
         id: build-cache-key
         run: |
-          if command -v shasum; then sum() { shasum -a 256 "$@"; } ; else sum() { sha256sum "$@"; }; fi
-          fragment=$(< package.json command grep 'version"\|"name"\|"files"\|"main"\|"build' | sum | command head -c8)
-          echo "key=build-${{ runner.os }}-${{ matrix.node }}-${{ hashFiles('**/src/**', '**/.swcrc', '**/.npmrc', '**/tsconfig*.json', '**/pnpm-lock.yaml', '.github/workflows/build.yml') }}-${fragment}" | tee -a $GITHUB_OUTPUT
+          echo "key=build-${{ runner.os }}-${{ matrix.node }}-${{ hashFiles('package.json', '**/src/**', '**/.swcrc', '**/.npmrc', '**/tsconfig*.json', '**/pnpm-lock.yaml', '.github/workflows/build.yml') }}" | tee -a $GITHUB_OUTPUT
         shell: bash
 
       - name: Restore build cache
@@ -52,7 +53,7 @@ jobs:
         name: Install pnpm
         id: pnpm-install
         with:
-          version: 7
+          version: 8
           run_install: false
 
         # See: https://github.com/pnpm/action-setup#use-cache-to-reduce-installation-time
@@ -76,28 +77,14 @@ jobs:
         if: steps.build_cache.outputs.cache-hit != 'true'
         run: pnpm install --frozen-lockfile --strict-peer-dependencies
 
-      # For rsync support in Windows
-      - uses: GuillaumeFalourd/[email protected]
-        if: ${{ startsWith(runner.os, 'windows') && steps.build_cache.outputs.cache-hit != 'true' }}
-
       - name: Build cache on ${{ runner.os }}
         if: steps.build_cache.outputs.cache-hit != 'true'
         shell: bash
         run: |
-          pnpm run -r build-dist
+          pnpm run dist
 
-      - name: Save built artefacts to cache
+      - name: Test build artifacts sanity
         if: steps.build_cache.outputs.cache-hit != 'true'
         shell: bash
         run: |
-          # Due to GitHub's stupid cp, need to use rsync instead.
-          for i in dist; do \
-            mkdir -p ${{ env.CACHE_DIR }}/"${MAIN_PACKAGE_PATH}" ; \
-            ls -la "${MAIN_PACKAGE_PATH}/$i"; \
-            echo rsync -a "${MAIN_PACKAGE_PATH}/$i" ${{ env.CACHE_DIR }}/"${MAIN_PACKAGE_PATH}/"; \
-            rsync -a "${MAIN_PACKAGE_PATH}/$i" ${{ env.CACHE_DIR }}/"${MAIN_PACKAGE_PATH}/"; \
-          done
-          echo ls -la ${{ env.CACHE_DIR }}
-          ls -la ${{ env.CACHE_DIR }}
-          echo ls -la ${{ env.CACHE_DIR }}/**
-          ls -la ${{ env.CACHE_DIR }}/**
+          pnpm run test:dist

.github/workflows/lint.yml

@@ -9,38 +9,36 @@ env:
 
 jobs:
   lint:
-    name: Lint on NodeJS ${{ matrix.node }}
+    name: Lint
     runs-on: ubuntu-latest
 
+    concurrency:
+      group: '${{ github.workflow }}-lint-${{ matrix.node }}-${{ github.head_ref || github.ref_name }}'
+      cancel-in-progress: true
+
     strategy:
       fail-fast: false
       matrix:
-        node: ['18.x']
+        node: [20]
 
     steps:
       - uses: actions/checkout@v3
         with:
           fetch-depth: 1
 
-      - name: Calculate a fragment of cache key
-        id: cache-key
-        run: |
-          echo "fragment=$(< package.json command grep '"lint"' | command sha256sum | command head -c8)" >> $GITHUB_OUTPUT
-        shell: bash
-
       - name: Restore test cache
         id: test_cache
         uses: actions/cache@v3
         with:
           path: ${{ env.CACHE_TEST_DIR }}
-          key: lint-${{ runner.os }}-${{ matrix.node }}-${{ hashFiles('**/*eslintrc*', '**/.*eslintrc*', '**/src/**', '**/pnpm-lock.yaml') }}-${{ steps.cache-key.outputs.fragment }}
+          key: lint-${{ runner.os }}-${{ matrix.node }}-${{ hashFiles('package.json', '**/*eslintrc*', '**/.*eslintrc*', '**/src/**', '**/pnpm-lock.yaml') }}
 
       - uses: pnpm/action-setup@v2
         if: steps.test_cache.outputs.cache-hit != 'true'
         name: Install pnpm
         id: pnpm-install
         with:
-          version: 7
+          version: 8
           run_install: false
 
       # See: https:
@@ -67,6 +65,5 @@ jobs:
 
       - if: steps.test_cache.outputs.cache-hit != 'true'
         run: |
-          pnpm run -r lint-typecheck
+          pnpm run lint-typecheck
           mkdir -p ${{ env.CACHE_TEST_DIR }}
-          touch ${{ env.CACHE_TEST_DIR }}/pass

.github/workflows/release.yml

@@ -20,21 +20,20 @@ on:
       #   default: 'false'
 
 env:
-  CACHE_DIR: installs
-  MAIN_PACKAGE_PATH: packages/legacy
+  CACHE_DIR: dist
 
 jobs:
   tests:
     # XXX: does not skip for some reason
     # if: github.events.inputs.skip_tests != 'true'
-    uses: ./.github/workflows/tests.yml
+    uses: ./.github/workflows/build-and-test.yml
 
   publish:
     needs: [tests]
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: ['16.x']
+        node: [18]
       fail-fast: false
 
     steps:
@@ -47,9 +46,7 @@ jobs:
         # results down the file
         id: build-cache-key
         run: |
-          if command -v shasum; then sum() { shasum -a 256 "$@"; } ; else sum() { sha256sum "$@"; }; fi
-          fragment=$(< package.json command grep 'version"\|"name"\|"files"\|"main"\|"build' | sum | command head -c8)
-          echo "key=build-${{ runner.os }}-${{ matrix.node }}-${{ hashFiles('**/src/**', '**/.swcrc', '**/.npmrc', '**/tsconfig*.json', '**/pnpm-lock.yaml', '.github/workflows/build.yml') }}-${fragment}" | tee -a $GITHUB_OUTPUT
+          echo "key=build-${{ runner.os }}-${{ matrix.node }}-${{ hashFiles('package.json', '**/src/**', '**/.swcrc', '**/.npmrc', '**/tsconfig*.json', '**/pnpm-lock.yaml', '.github/workflows/build.yml') }}" | tee -a $GITHUB_OUTPUT
         shell: bash
 
       - uses: actions/setup-node@v3
@@ -62,7 +59,7 @@ jobs:
         name: Install pnpm
         id: pnpm-install
         with:
-          version: 7
+          version: 8
           run_install: false
 
       # See: https:
@@ -84,56 +81,32 @@ jobs:
       - name: Install dependencies
         run: pnpm install --frozen-lockfile --strict-peer-dependencies
 
-      # For rsync support in Windows
-      - uses: GuillaumeFalourd/[email protected]
-        if: startsWith(runner.os, 'windows')
-
       - name: Restore cache
         id: build_cache
         uses: actions/cache@v3
         with:
           path: ${{ env.CACHE_DIR }}
           key: ${{ steps.build-cache-key.outputs.key }}
 
-      - name: Restore cache to working directory
-        shell: bash
-        run: |
-          echo ls -la ${{ env.CACHE_DIR }}/
-          ls -la ${{ env.CACHE_DIR }}/
-          echo ls -la ${{ env.CACHE_DIR }}/*
-          ls -la ${{ env.CACHE_DIR }}/*
-          echo ls -la .
-          ls -la .
-          for i in dist; do \
-            echo rsync -a ${{ env.CACHE_DIR }}/"${MAIN_PACKAGE_PATH}/$i" "${MAIN_PACKAGE_PATH}/"; \
-            rsync -a ${{ env.CACHE_DIR }}/"${MAIN_PACKAGE_PATH}/$i" "${MAIN_PACKAGE_PATH}/"; \
-          done
-          echo ls -la .
-          ls -la .
-          echo ls -la "${MAIN_PACKAGE_PATH}"/dist
-          ls -la "${MAIN_PACKAGE_PATH}"/dist
-          echo ls -la "${MAIN_PACKAGE_PATH}"/dist/*
-          ls -la "${MAIN_PACKAGE_PATH}"/dist/*
-
       - name: Create a new version
-        if: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.next_version != 'skip' }}
+        if: ${{ github.event_name == 'workflow_call' || github.event_name == 'workflow_dispatch' && github.event.inputs.next_version != 'skip' }}
         shell: bash
         run: |
           git config --global user.name "${GITHUB_ACTOR}"
           git config --global user.email "${GITHUB_ACTOR}@users.noreply.github.com"
 
-          cd "${MAIN_PACKAGE_PATH}"
-          pnpm version --new-version ${{ github.event.inputs.next_version }}
-          git add -u
-          git commit -m "chore: Release ${{ github.event.inputs.next_version }}"
-          git tag -a "${{ github.event.inputs.next_version }}" -mBump
+          # cd to where project package.json is
+          # pnpm version \
+          #   --new-version ${{ github.event.inputs.next_version }} \
+          #   --message "chore: Release ${{ github.event.inputs.next_version }}"
+          pnpm bump-version ${{ github.event.inputs.next_version }}
+
           # Push commit along with tag
           git push origin --tags :
 
       - name: Publish to npm
         run: |
-          cd "${MAIN_PACKAGE_PATH}"
-          diff -u {,dist/}package.json | \
+          diff -u {,dist/}package.json || \
             cp {,dist/}package.json
           pnpm publish dist --access public --no-git-checks
         env: