Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CLC Alps eodc backend #42

Merged
merged 3 commits into from
Nov 3, 2023
Merged

add CLC Alps eodc backend #42

merged 3 commits into from
Nov 3, 2023

Conversation

ValentinaHutter
Copy link
Collaborator

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ValentinaHutter
Copy link
Collaborator Author

ValentinaHutter commented Oct 31, 2023

@clausmichele is it okay if I put the notebook under /tutorial/part2 as well?

@jdries
Copy link
Collaborator

jdries commented Oct 31, 2023

@ValentinaHutter for me, the notebook would make more sense if it actually also shows how to compute the difference between timestamps in openEO. Meaning, it's not that it's not allowed to compute the difference locally, but doing so in an openEO notebook could be misinterpreted as not being able to do it in openEO.

@clausmichele
Copy link
Collaborator

@ValentinaHutter I also updated the client side version here: https://github.com/pangeo-data/pangeo-openeo-BiDS-2023/blob/main/tutorial/part2/openEO%20-%20Client%20Side%20Land%20Cover%20Alps.ipynb

I compute the difference in openEO. For my notebook, it's necessary to merge the drop_dimension fix PR here: Open-EO/openeo-processes-dask#188
and if possible also the merge_cubes fix here (but works as well setting the band dimension to "bands"): Open-EO/openeo-processes-dask#166

@ValentinaHutter ValentinaHutter merged commit 8133d60 into main Nov 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants