Rebasing Yuvi's setup_py branch with main
#110
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
save_main_session doesn't seem to work with flink, and Charles tells me it is meant to be a hack anyway - and this is the better way to go longer term
for more information, see https://pre-commit.ci
yuvipanda
reviewed
Oct 13, 2023
| """ | ||
| file = dedent( | ||
| """ | ||
| import setuptools |
There was a problem hiding this comment.
I would suggest moving this template out into its own file.
This generation also needs to be watched closely for code injection based attacks.
yuvipanda
reviewed
Oct 13, 2023
| setuptools.setup( | ||
| name='recipe', | ||
| version='0.1', | ||
| # FIXME: Support all the files we need to here! |
There was a problem hiding this comment.
This fixme is basically the important part - it should contain all the files we wanna package and send into the runner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#92