Flink Unique Job Names #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 29, 2023 07:46
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 95.53% 95.60% +0.06%
==========================================
Files 14 14
Lines 493 500 +7
==========================================
+ Hits 471 478 +7
Misses 22 22 ☔ View full report in Codecov by Sentry. |
added 2 commits
November 30, 2023 08:06
ranchodeluxe
added
the
test-flink
moradology
approved these changes
Feb 13, 2024
| """ | ||
| if self.bakery_class == FlinkOperatorBakery: | ||
| unique_suffix = "".join( | ||
| secrets.choice(string.ascii_letters + string.digits) for _ in range(5) |
There was a problem hiding this comment.
Not sure that it matters, but I like random for this kind of thing so that a seed can be used for predictable outputs
moradology
reviewed
Feb 19, 2024
| @@ -168,6 +169,21 @@ def autogenerate_job_name(self): | |||
|
|
|||
| return job_name | |||
|
|
|||
| def add_unique_suffix_to_flink_jobs(self, per_recipe_unique_job_name): | |||
There was a problem hiding this comment.
In another PR, we should probably go through and figure out which behaviors we can expect runner implementations to sort out so that Bake can be thin and runner independent. It'd be great for it to not know anything at all about implementation details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #132