Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error and exit if config file isn't readable #88

Merged
merged 6 commits into from
Sep 1, 2023

Conversation

yuvipanda
Copy link
Collaborator

Fixes #73

@cisaacstern
Copy link
Member

Thanks for this @yuvipanda! Looks like the tweak in 502735b was all we needed to get it to work 😄 .

Sort of an https://github.com/yuvipanda/opposite-day situation! 😆

@cisaacstern
Copy link
Member

Hmm I spoke too soon... now we have errors if the default config is not found...

'Could not read config from file pangeo_forge_runner_config.py. Make sure it exists and is readable\n'

🤔

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (ce14ad5) 95.75% compared to head (fd77b7d) 95.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   95.75%   95.79%   +0.03%     
==========================================
  Files          13       13              
  Lines         424      428       +4     
==========================================
+ Hits          406      410       +4     
  Misses         18       18              
Files Changed Coverage Δ
pangeo_forge_runner/commands/base.py 98.48% <100.00%> (+0.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisaacstern
Copy link
Member

Merging this as a big step forward but opened #100 to address remaining corner cases.

@cisaacstern cisaacstern merged commit 35e7732 into main Sep 1, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise error if config file doesn't exist?
2 participants