Skip to content

Commit

Permalink
chore: expurgate conn.asyncWrite/asyncWritev
Browse files Browse the repository at this point in the history
Besides, bump up and update some GitHub Actions.
  • Loading branch information
panjf2000 committed Jan 11, 2025
1 parent a15081a commit 73c3ab3
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 9 deletions.
13 changes: 11 additions & 2 deletions .github/release-drafter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ autolabeler:
title:
- /fix/i
- /bug/i
- /patch/i
- /resolve/i
- label: docs
files:
- '*.md'
Expand All @@ -59,6 +59,15 @@ autolabeler:
- /update/i
- /remove/i
- /delete/i
- label: optimization
title:
- /opt:/i
- /refactor/i
- /optimize/i
- /improve/i
- /update/i
- /remove/i
- /delete/i
- label: new feature
title:
- /feat:/i
Expand All @@ -75,7 +84,7 @@ autolabeler:
- label: chores
title:
- /chore/i
- /\bmisc\b/i
- /misc/i
- /cleanup/i
- /clean up/i
- label: major
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-drafter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
# echo "GHE_HOST=${GITHUB_SERVER_URL##https:\/\/}" >> $GITHUB_ENV

# Drafts your next Release notes as Pull Requests are merged into "master"
- uses: release-drafter/release-drafter@v5
- uses: release-drafter/release-drafter@v6
# (Optional) specify config name to use, relative to .github/. Default: release-drafter.yml
# with:
# config-name: my-config.yml
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:
run: go test -v -race -coverprofile="codecov.report" -covermode=atomic -timeout 15m -failfast

- name: Upload the code coverage report to codecov.io
uses: codecov/codecov-action@v4
uses: codecov/codecov-action@v5
with:
files: ./codecov.report
flags: unittests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_gc_opt.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:
run: go test -v -race -tags=gc_opt -coverprofile="codecov.report" -covermode=atomic -timeout 15m -failfast

- name: Upload the code coverage report to codecov.io
uses: codecov/codecov-action@v4
uses: codecov/codecov-action@v5
with:
files: ./codecov.report
flags: unittests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_poll_opt.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ jobs:
run: go test -v -tags=poll_opt -coverprofile="codecov.report" -covermode=atomic -timeout 10m -failfast

- name: Upload the code coverage report to codecov.io
uses: codecov/codecov-action@v4
uses: codecov/codecov-action@v5
with:
files: ./codecov.report
flags: unittests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_poll_opt_gc_opt.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ jobs:
run: go test -v -tags=poll_opt,gc_opt -coverprofile="codecov.report" -covermode=atomic -timeout 10m -failfast

- name: Upload the code coverage report to codecov.io
uses: codecov/codecov-action@v4
uses: codecov/codecov-action@v5
with:
files: ./codecov.report
flags: unittests
Expand Down
2 changes: 0 additions & 2 deletions connection_unix.go
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,6 @@ func (c *conn) asyncWrite(a any) (err error) {
}()

if !c.opened {
c.outboundBuffer.Release() // release all remaining bytes in the outbound buffer
return net.ErrClosed
}

Expand All @@ -274,7 +273,6 @@ func (c *conn) asyncWritev(a any) (err error) {
}()

if !c.opened {
c.outboundBuffer.Release() // release all remaining bytes in the outbound buffer
return net.ErrClosed
}

Expand Down

0 comments on commit 73c3ab3

Please sign in to comment.