Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: release outboundBuffer immediately in AsyncWrite(v) if Conn is closed #673

Merged
merged 3 commits into from
Jan 11, 2025

Conversation

panjf2000
Copy link
Owner

Fixes #672

@github-actions github-actions bot added the enhancement New feature or request label Jan 11, 2025
@panjf2000 panjf2000 added optimization Some small optimizations performance labels Jan 11, 2025
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.65%. Comparing base (e9a1101) to head (f2750ec).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
connection_windows.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #673      +/-   ##
==========================================
+ Coverage   79.43%   79.65%   +0.21%     
==========================================
  Files          21       21              
  Lines        2514     2516       +2     
==========================================
+ Hits         1997     2004       +7     
  Misses        397      397              
+ Partials      120      115       -5     
Flag Coverage Δ
unittests 79.65% <85.71%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 changed the title opt: release outboundBuffer immediately in AsyncWrite/AsyncWritev if Conn is closed opt: release outboundBuffer immediately in AsyncWrite(v) if Conn is closed Jan 11, 2025
@panjf2000 panjf2000 merged commit a15081a into dev Jan 11, 2025
35 checks passed
@panjf2000 panjf2000 deleted the conn-buffer-release branch January 11, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization Some small optimizations performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: memory leaks of disconnected connections
1 participant