Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a line that exports environment variables to the bashrc #975

Merged
merged 3 commits into from
Jun 9, 2020

Conversation

joshua-liberman
Copy link
Collaborator

@joshua-liberman joshua-liberman commented Jun 8, 2020

Description

This fix links the Panoptes env file to the bashrc from within the install-pocs script.

Fixes #973

Related Issue

Previously, the environment variables weren't getting set after a restart, and the bashrc file had to be manually edited to link the environment variables.

How Has This Been Tested?

This fix has not been tested on a clean install but was tested on an existing Ubuntu 20.03 Panoptes development system. The env file was removed beforehand as well as any references to Panoptes environment variables in the bashrc.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #975 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #975      +/-   ##
===========================================
+ Coverage    68.40%   68.42%   +0.02%     
===========================================
  Files           95       95              
  Lines         9500     9500              
  Branches       873      873              
===========================================
+ Hits          6498     6500       +2     
+ Misses        2838     2836       -2     
  Partials       164      164              
Impacted Files Coverage Δ
src/panoptes/pocs/dome/astrohaven.py 79.27% <0.00%> (+1.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c67c19...b544e61. Read the comment docs.

Copy link
Member

@wtgee wtgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for getting this in! Can you add the suggestion then I'll merge.

scripts/install/install-pocs.sh Outdated Show resolved Hide resolved
@wtgee wtgee merged commit 727049b into panoptes:develop Jun 9, 2020
@joshua-liberman joshua-liberman deleted the install-pocs-fixes-973 branch June 9, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants