Update panolint-ruby to bump rubocop and patch vulnerability #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates our version of panolint-ruby, which updates rubocop, which updates rexml to a version that fixes CVE-2024-39908.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 190 190
Branches 90 90
=========================================
Hits 190 190 ☔ View full report in Codecov by Sentry. |
jordannb
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates our version of panolint-ruby, which updates rubocop, which updates rexml to a version that fixes CVE-2024-39908.
Before merging:
README.mdand update this PRCHANGELOG.md, add an entry following Keep a Changelog guidelines with semantic versioning☝️ this PR does not change the code being benchmarked, so we do not need new benchmarks. I considered adding a note in the changelog but decided not to because I don't see any past rubocop/panolint upgrades in the changelog and think our users will not care about this change as it will not impact their use of the gem.