Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.10.0 #346

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Version 1.10.0 #346

merged 3 commits into from
Sep 17, 2024

Conversation

JacobEvelyn
Copy link
Member

Before merging:

  • Copy the table printed at the end of the latest benchmark results into the README.md and update this PR
  • If this change merits an update to CHANGELOG.md, add an entry following Keep a Changelog guidelines with semantic versioning

@JacobEvelyn JacobEvelyn requested a review from ms-ati September 17, 2024 15:24
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6873b97) to head (5181eb3).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #346   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          190       190           
  Branches        90        90           
=========================================
  Hits           190       190           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated

**Gem enhancements:**

- Reduced unzipped gem size from 312 kB to 68 kB [[#345](https://github.com/panorama-ed/memo_wise/pull/345)]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tagliala I wanted to double-check your numbers but got different results. Here's what I did:

$ gem install memo_wise # installs v1.9.0
$ gem info memo_wise
$ du -sh /path/to/ruby/3.3.3/gems/memo_wise-1.9.0
 312K	/Users/jevelyn/.gem/ruby/3.3.3/gems/memo_wise-1.9.0

$ gem build memo_wise.gemspec
$ mv memo_wise-1.10.0.gem ~/Downloads
$ gem unpack ~/Downloads/memo_wise-1.10.0.gem
$ du -sh ~/Downloads/memo_wise-1.10.0
 68K	./memo_wise-1.10.0/

did I do something incorrectly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JacobEvelyn sorry, I just realized that "unzipped" is incorrect

I was referring to the compressed version, I've noticed it was "too big for the source code" here:

https://rubygems.org/gems/memo_wise

Screen attached:

image

This will change to 19 KB after the new release

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I see it as 20 kB on my machine for some reason (probably slight differences around the CHANGELOG updates for v1.10.0); I'll change.

Copy link
Contributor

@tagliala tagliala Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated screen from rubygems

image

@JacobEvelyn JacobEvelyn mentioned this pull request Sep 17, 2024
2 tasks
@JacobEvelyn JacobEvelyn merged commit f00ab58 into main Sep 17, 2024
14 checks passed
@JacobEvelyn JacobEvelyn deleted the version-1.10.0 branch September 17, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants