Rockchip fixes + add rock5a radxa board support #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 11, 2024 21:43
Fix following: configure: error: libmount_mountfd_support selected, but required mount FDs based API not available More info:https://lists.openembedded.org/g/openembedded-core/topic/scarthgap_patch/108054377 Signed-off-by: Marek Belisko <[email protected]>
Fix following: WARNING - warning: the default selection PLATFORM_QEMU (defined at /repo/Kconfig:174) of <choice> (defined at /repo/Kconfig:136) is not contained in the choice Signed-off-by: Marek Belisko <[email protected]>
Signed-off-by: Marek Belisko <[email protected]>
Signed-off-by: Marek Belisko <[email protected]>
asac
reviewed
Oct 18, 2024
| part loader2 --offset 16384s --fixed-size 4096K --fstype=none --part-name loader2 --source rawcopy --sourceparams="file=u-boot.${UBOOT_SUFFIX}" | ||
| part atf --offset 24576s --fixed-size 4096K --fstype=none --part-name atf | ||
| -part / --label rootfsA --active --fstype=ext4 --part-name rootfsA --source rootfs --part-type ${ROOT_DPS} | ||
| +part / --label root --active --fstype=ext4 --part-name root --source rootfs --part-type ${ROOT_DPS} |
There was a problem hiding this comment.
maybe this could be upstreamable if this was a variable?
There was a problem hiding this comment.
@nandra have you opened the upstreaming threat on this? I think first choice would be to use 'root' everywhere or if not use ${RK_ROOT_LABEL} or something....
asac
reviewed
Oct 18, 2024
CONFIG_CMD_SETEXPR is mandatory anyways so put it in common config. Signed-off-by: Marek Belisko <[email protected]>
|
once wks change has been submitted upstream feel free to merge this. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.