Fix Submit batch for messages of type string #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikMogensen
requested review from
paolosalvatori and
SeanFeldman
as code owners
|
Nit: The description is missing they key of the fix: GetBody() vs GetBody(). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #633
This PR changes the reading of messages of type string to be read using GetBody<string>() instead of GetBody<Stream>(), thus avoiding getting unwanted text in the message.
Also did an auto format which changed some whitespace.
Thanks to @Anshuljkt for his work on #764, which helped in creating this PR and to @flower7434 for the tip about reading messages.