Export/Import Properties of CorrelationFilter #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robionekenobi
requested review from
paolosalvatori,
SeanFeldman and
ErikMogensen
as code owners
SeanFeldman
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Thank you for the PR, @robionekenobi.
A few minor updates if you don't mind.
Co-authored-by: Sean Feldman <[email protected]>
Co-authored-by: Sean Feldman <[email protected]>
Co-authored-by: Sean Feldman <[email protected]>
Co-authored-by: Sean Feldman <[email protected]>
Co-authored-by: Sean Feldman <[email protected]>
SeanFeldman
reviewed
Nov 19, 2024
SeanFeldman
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version, when exporting topics, the eventual properties of the CorrelationFilter of a subscription is not exported, nor imporetd
This pull requesrt correct this