Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#686: Move Queue management functions to separate class #816

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

supereddie
Copy link

First part of refactoring the ServiceBusHelper class #686. This is a fairly straight-forward 'move code to different class' to simplify the changes, and to set-up a basic structure of classes.

This part is moving Queue 'management actions' - that is, actions for Queues that need the Microsoft.ServiceBus.NamespaceManager to work.

@supereddie
Copy link
Author

I'm not sure about code-style guidelines and such, with things about Resharper ignore-comments and #region usage for example, so any remarks are appreciated.

@ErikMogensen
Copy link
Collaborator

I'm not sure about code-style guidelines and such, with things about Resharper ignore-comments and #region usage for example, so any remarks are appreciated.

We don't have any formal recommendation for those issues and it is not consistent in the existing code. So do as you wish regarding that.

I took a quick look at the changes and it looks great. I'll take a closer look when I get time. This will be a great help when migrating to the latest ServiceBus SDK. Have you considered making one or more shared base classes for queues, topics and subscriptions? That may be a future task - if it is a good thing...

@supereddie
Copy link
Author

I took a quick look at the changes and it looks great. I'll take a closer look when I get time. This will be a great help when migrating to the latest ServiceBus SDK.

I was wondering for the SDK migration if it would be useful to have our own custom types representing things in the ServiceBus, instead of using the SDK types. It does provide some additional abstraction and will make the switch smoother, but it can be very tricky and mistakes are easily made. In the refactoring of the ServiceBusHelper it could be one of the (last?) tasks to do.

Have you considered making one or more shared base classes for queues, topics and subscriptions? That may be a future task - if it is a good thing...

I have thought about it, but at the moment I don't yet know what is useful to put in a base class since I haven't even looked at the code of other entity types😃When it is time, I'll probably name it something like ServiceBusEntity to make clear it is a generalized class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants