🐛 fix searching result on latest version dependency analysis #64
+9
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running analyses with dependencies rely on querying results from the proper application.
There's some cases where several dependencies are available, and it's failing to bring the latest version.
i.e. This is a real use case example:
To run our app
AUTOTATOR_INDELS (v1.0.0)
we rely onANNOT_INDELS
as a dependency.But some old samples may have more than 1 version of this app. In this case, the Experiment
E-H-112886-T1-1-D1-1
has 6ANNOT_INDELS
ran matched against 2 different normals, and has versionv1.0.0
,v2.0.0
andv3.0.0
for each.Before:
In this case we want the
get_dependency_results()
method to query thelatest
analysis. And when running it, it's checking thev1.0.0
not thev3.0.0
that is the latest one.After:
After this fix, we don't check results for each potential result of the list, but first I create a candidates list, sort it by application pk, and grab the higher one (latest version). After this the results assertion can be done.