Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft to refine the direction we want to go with the refactor.
<NeuroNoise />
default props use vanilla defs and no longer rely on the default preset. So we can have different values for the props defaults and the default preset. For example, gray instead of the current blue if nocolorMid
is provided.min
,max
, anddefaultValue
. Similarly to the React package, we don't need to rely on deriving the default preset anymore.👉 This is still in a demo stage to have a first look at the refactor. To keep the diff readable, not all params are using the vanilla def yet, and
params
will be in object form to avoid having to useparams.find()
andas
workarounds.