Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chat members to the chat info #404

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

yuraiz
Copy link
Contributor

@yuraiz yuraiz commented Nov 19, 2022

image

@yuraiz yuraiz force-pushed the chat-info-members branch 2 times, most recently from 1011416 to 7dcf1fb Compare January 3, 2023 10:52
data/resources/style.css Outdated Show resolved Hide resolved
.editorconfig Outdated Show resolved Hide resolved
data/resources/resources.gresource.xml Outdated Show resolved Hide resolved
data/resources/ui/content-chat-info-member-row.ui Outdated Show resolved Hide resolved
data/resources/ui/content-chat-info-window.ui Outdated Show resolved Hide resolved
@yuraiz yuraiz requested a review from melix99 January 9, 2023 09:58
@yuraiz yuraiz marked this pull request as ready for review January 10, 2023 14:47
@melix99
Copy link
Collaborator

melix99 commented Jan 20, 2023

Please consider reorganizing the commit history a bit. Currently it's a bit messy.

For example, consider creating a commit for each feature/bug fix/structural change instead of creating one commit every time you make a change in a file.

@melix99
Copy link
Collaborator

melix99 commented Feb 5, 2023

So, there are some things about the implementation that can definitely be improved.

First, the ChatMember gobject is basically useless because it doesn't have properties. Actually, I think that it doesn't even need to be a gobject at all because it seems that these objects can't be updated from tdlib at all, so I suggest creating a Boxed type instead (see tdlib/mod.rs).

Then, I suggest moving the get_supergroup_members inside Supergroup via a new async members() function. This should probably return a GListStore of the boxed ChatMember type.

@melix99
Copy link
Collaborator

melix99 commented Feb 6, 2023

Design-wise I think I'd prefer not having a AdwViewSwitcher in the ChatInfoWindow, also because we'll have many more items in the future. What about creating a row like that:

image

@melix99 melix99 marked this pull request as draft March 22, 2023 22:12
@melix99 melix99 added this to the Telegrand 0.1 milestone Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants