MessageListView and pinned messages #506
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melix99
commented
Mar 14, 2023
Comment on lines
55
to
65
| fn show_message_menu(&self, x: i32, y: i32) { | ||
| let obj = self.obj(); | ||
| let chat_history = obj.ancestor(ChatHistory::static_type()).unwrap(); | ||
| let menu = chat_history | ||
| .downcast_ref::<ChatHistory>() | ||
| .unwrap() | ||
| .message_menu(); | ||
|
|
||
| menu.set_pointing_to(Some(&gdk::Rectangle::new(x, y, 0, 0))); | ||
| menu.unparent(); | ||
| menu.set_parent(&*obj); | ||
| menu.popup(); | ||
| // let obj = self.obj(); | ||
| // let chat_history = obj.ancestor(ChatHistory::static_type()).unwrap(); | ||
| // let menu = chat_history | ||
| // .downcast_ref::<ChatHistory>() | ||
| // .unwrap() | ||
| // .message_menu(); | ||
|
|
||
| // menu.set_pointing_to(Some(&gdk::Rectangle::new(x, y, 0, 0))); | ||
| // menu.unparent(); | ||
| // menu.set_parent(&*obj); | ||
| // menu.popup(); | ||
| } |
There was a problem hiding this comment.
We need to handle message menus in a way that's not dependent on ChatHistory anymore.
melix99
force-pushed
the
melix99/pinned-messages
branch
from
8776167
to
96981cd
Compare
This a new major change to the chat history. We now have a new widget component, called MessageListView, which can display messages... in a list view. For now it's basically the same as the internal list view in ChatHistory, but in the future it will support showing messages from other contexts, like pinned messages history, reply threads, post comments, etc.
"content" -> "session"
melix99
force-pushed
the
melix99/pinned-messages
branch
from
96981cd
to
ffa58a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.