Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: two-factor authentication #8012

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from
Open

Feature: two-factor authentication #8012

wants to merge 15 commits into from

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Oct 25, 2024

Proposed change

This pretty much entirely uses allauth's handling of totp and just kinda connects it to our frontend.

Screenshot 2024-10-25 at 10 55 34 AM Screenshot 2024-10-25 at 11 01 26 AM Screenshot 2024-10-25 at 11 01 52 AM Screenshot 2024-10-25 at 10 55 09 AM

Closes #424

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@paperless-ngx-secretary paperless-ngx-secretary bot added backend frontend non-trivial Requires approval by several team members labels Oct 25, 2024
@github-actions github-actions bot added the enhancement New feature label Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.52%. Comparing base (36ecb85) to head (f80e85e).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8012      +/-   ##
==========================================
+ Coverage   97.50%   97.52%   +0.01%     
==========================================
  Files         475      475              
  Lines       19866    20006     +140     
  Branches     1564     1644      +80     
==========================================
+ Hits        19370    19510     +140     
+ Misses        496      493       -3     
- Partials        0        3       +3     
Flag Coverage Δ
backend 96.40% <100.00%> (+0.02%) ⬆️
frontend 98.76% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chwiese
Copy link

chwiese commented Nov 12, 2024

Thank you for working on this @shamoon. I saw that allauth supports WebAuthn (Passkeys) for MFA. Would you consider supporting that in addition to TOTP please?

@shamoon shamoon marked this pull request as ready for review November 13, 2024 00:20
@shamoon shamoon requested review from a team as code owners November 13, 2024 00:20
Copy link
Member

@stumpylog stumpylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to test it out too, but a couple minor thoughts

Pipfile.lock Outdated Show resolved Hide resolved
src/paperless/views.py Outdated Show resolved Hide resolved
src/paperless/views.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature frontend non-trivial Requires approval by several team members
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants