-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: two-factor authentication #8012
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8012 +/- ##
==========================================
+ Coverage 97.50% 97.52% +0.01%
==========================================
Files 475 475
Lines 19866 20006 +140
Branches 1564 1644 +80
==========================================
+ Hits 19370 19510 +140
+ Misses 496 493 -3
- Partials 0 3 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thank you for working on this @shamoon. I saw that allauth supports WebAuthn (Passkeys) for MFA. Would you consider supporting that in addition to TOTP please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to test it out too, but a couple minor thoughts
Proposed change
This pretty much entirely uses allauth's handling of totp and just kinda connects it to our frontend.
Closes #424
Type of change
Checklist:
pre-commit
hooks, see documentation.