Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add individual options as alternative to configuration string #11

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

tsalo
Copy link
Contributor

@tsalo tsalo commented Oct 3, 2024

Closes #9.

Changes proposed:

  • Reorganize the argument parser.
  • Add individual parameters as an alternative to the configuration string:
    • --method: One of the denoising methods. Default is "optimal-fro". This parameter is mutually exclusive with --conf.
    • --patch-shape: Positive integer. Default is 11.
    • --patch-overlap: Positive integer. Default is 5.
    • --recombination: "weighted" or "mean". Default is "weighted".
    • --mask-threshold: Integer. Default is 10. I noticed this was in the DenoiseParameters, but wasn't documented in the --conf description.
  • Check values with custom argument types and actions.

Copy link
Owner

@paquiteau paquiteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's Great stuff! I learned a few things while reviewing, so thanks!

@paquiteau paquiteau merged commit a002f1e into paquiteau:master Oct 4, 2024
2 of 3 checks passed
@tsalo tsalo mentioned this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split --conf into individual parameters?
2 participants