Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STY] run isort rules via ruff/pre-commit #20

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[STY] run isort rules via ruff/pre-commit #20

wants to merge 4 commits into from

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Oct 7, 2024 •
edited
Loading

  • implement "isort rules" of ruff
  • remove isort as a dev dependency (I did not see it used in CI)
  • add pre-commit to run black, codespell, ruff before commit to ensure only clean commits are in
  • runn linters and style checks in CI via pre-commit (so that is is run the same way locally and in CI)
  • silence other RUFF errors for now

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Oct 7, 2024

Side effect of this PR: this also runs ruff / black on the tests and examples

@Remi-Gau Remi-Gau marked this pull request as ready for review October 7, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Remi-Gau