ecies: use align_num value #12139
Open
ecies: use align_num value #12139
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Oct 28, 2024
mattsse
reviewed
Nov 1, 2024
crates/net/ecies/src/algorithm.rs
Outdated
Comment on lines
734
to
738
| /// return num alignment value | ||
| #[inline] | ||
| const fn align_num(num: usize, align: usize) -> usize { | ||
| (num + (align - 1)) & !(align - 1) | ||
| } |
There was a problem hiding this comment.
@DaniPopes need help here 🙃, is this euqivalent
There was a problem hiding this comment.
https://stackoverflow.com/questions/45213511/formula-for-memory-alignment
https://stackoverflow.com/questions/14561402/how-is-this-size-alignment-working , some c code like linux kernel, and hack's delight introduced this
There was a problem hiding this comment.
this should be equal to ".next_multiple_of"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.