Skip to content

refactor: Move trait dedup fn into native fn #16446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

refactor: Move trait dedup fn into native fn #16446

wants to merge 4 commits into from

Conversation

gejeduck
Copy link
Contributor

closes #16439

@gejeduck gejeduck requested review from mattsse and Rjected as code owners May 23, 2025 16:52
@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker May 23, 2025
graphite-app[bot]
graphite-app bot reviewed May 23, 2025
View reviewed changes
mattsse
mattsse requested changes May 26, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, let's also move the actual dedup logic into the individual NewPooled types and then update the current trait impl with just Self::dedup(self)

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker May 26, 2025
@mattsse mattsse added the A-networking Related to networking in general label May 26, 2025
@gejeduck gejeduck requested a review from mattsse May 26, 2025 12:13
mattsse
mattsse requested changes May 26, 2025
View reviewed changes
@gejeduck gejeduck requested a review from mattsse May 26, 2025 13:49
@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Jun 17, 2025
@github-actions github-actions bot closed this Jun 24, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general S-stale This issue/PR is stale and will close with no further activity
Projects
Reth Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move trait dedup functions into NewPooledTransactionHashes::dedup
2 participants
@gejeduck @mattsse