Skip to content

chore: remove unused features #16963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2025
Merged

chore: remove unused features #16963

merged 3 commits into from
Jun 21, 2025

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 20, 2025

No description provided.

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Jun 20, 2025
@mattsse mattsse added the dependencies Pull requests that update a dependency file label Jun 20, 2025
@mattsse mattsse marked this pull request as draft June 20, 2025 08:20
alloy-consensus.workspace = true
alloy-network.workspace = true

# optimism
op-alloy-consensus.workspace = true
op-alloy-rpc-types.workspace = true
reth-optimism-primitives = { workspace = true, features = ["serde", "serde-bincode-compat"] }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These serde features are required for some trait implementations, I think it was OpReceipt.

@mattsse mattsse marked this pull request as ready for review June 21, 2025 07:27
@mattsse mattsse requested a review from fgimenez as a code owner June 21, 2025 07:27
@mattsse
Copy link
Collaborator Author

mattsse commented Jun 21, 2025

after we made the deps optional these errors are resolved

@mattsse mattsse merged commit 9939164 into main Jun 21, 2025
45 checks passed
@mattsse mattsse deleted the matt/remove-unused-features2 branch June 21, 2025 07:38
@github-project-automation github-project-automation bot moved this from Backlog to Done in Reth Tracker Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants