fix: check payload length and consumed buf for pooled tx

[Rjected]

This is one of the bugs found by #5125, we were previously allowing decoding of legacy transactions that were shorter than their payload length, as well as legacy transactions that were longer than their payload length. We will need to similarly check header lengths in other manual decodings.

Tests are added that contain RLP strings generated by the fuzzer.

[codecov]

Codecov Report

Merging #5153 (e0f2a02) into main (4dc15c3) will decrease coverage by 9.05%.
Report is 70 commits behind head on main.
The diff coverage is 12.50%.

❗ Current head e0f2a02 differs from pull request most recent head 5bffcc6. Consider uploading reports for the commit 5bffcc6 to get more accurate results

Files	Coverage Δ
crates/primitives/src/transaction/tx_value.rs	26.43% <0.00%> (-42.49%)	⬇️
crates/primitives/src/transaction/pooled.rs	49.68% <15.25%> (-8.79%)	⬇️

... and 220 files with indirect coverage changes

Flag	Coverage Δ
integration-tests	17.03% <12.50%> (-9.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
reth binary	6.18% <ø> (-19.61%)	⬇️
blockchain tree	0.00% <ø> (-28.47%)	⬇️
pipeline	0.00% <ø> (-5.05%)	⬇️
storage (db)	16.66% <ø> (-13.32%)	⬇️
trie	0.00% <ø> (-22.54%)	⬇️
txpool	32.20% <ø> (-9.18%)	⬇️
networking	28.84% <ø> (-2.06%)	⬇️
rpc	23.65% <ø> (-2.83%)	⬇️
consensus	0.88% <ø> (-24.19%)	⬇️
revm	1.33% <ø> (-8.52%)	⬇️
payload builder	7.95% <ø> (-6.21%)	⬇️
primitives	20.98% <12.50%> (-8.20%)	⬇️

[mattsse]

nice!

only naming nits

fat fingered approval

[mattsse]

rlp 👍

there's another thing we should do (separately):

currently, we're always consuming the &mut & however ideally we only advance this when decoding is successful.

see Decode derive macro template for example

[mattsse]

good to merge @Rjected ?

[mattsse]

needs rebase @Rjected