Clean up some code smells discovered by Sonar Quebe

paradisec-archive · Oct 28, 2023 · 576f7df · 576f7df
1 parent e26fe56
commit 576f7df
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/app/assets/stylesheets/_layout_style.scss b/app/assets/stylesheets/_layout_style.scss
@@ -205,7 +205,6 @@ body.bp {
     margin-bottom: 8px;
     width: 100%;
     box-sizing: border-box;
-    -moz-box-sizing: border-box;
     legend {
       font-size: 18px;
       text-shadow: grey 2px 2px 3px;
@@ -322,8 +321,7 @@ body.bp {
       padding: 4px 0;
       border: solid 1px #E5E5E5;
       box-shadow: rgba(0, 0, 0, 0.1) 0px 0px 8px;
-      background: -webkit-linear-gradient(top, #FFFFFF, #EEEEEE 1px, #FFFFFF 25px);
-      background: -moz-linear-gradient(top, #FFFFFF, #EEEEEE 1px, #FFFFFF 25px);
+      background: linear-gradient(top, #FFFFFF, #EEEEEE 1px, #FFFFFF 25px);
     }
 
     select.bool {
@@ -353,10 +351,7 @@ body.bp {
     border: solid 1px #E5E5E5;
     background: #FFFFFF;
     box-shadow: rgba(0, 0, 0, 0.1) 0px 0px 8px;
-    background: -webkit-linear-gradient(top, #FFFFFF, #EEEEEE 1px, #FFFFFF 25px);
-    background: -moz-linear-gradient(top, #FFFFFF, #EEEEEE 1px, #FFFFFF 25px);
-    background: -ms-linear-gradient(top, #FFFFFF, #EEEEEE 1px, #FFFFFF 25px);
-    background: -o-linear-gradient(top, #FFFFFF, #EEEEEE 1px, #FFFFFF 25px);
+    background: linear-gradient(top, #FFFFFF, #EEEEEE 1px, #FFFFFF 25px);
     &:hover, &:focus {
       box-shadow: rgba(0, 0, 0, 0.25) 0px 0px 8px;
     }
@@ -371,7 +366,6 @@ body.bp {
   input[type="text"], input[type="email"], input[type="password"], textarea {
     width: 100%;
     box-sizing: border-box;
-    -moz-box-sizing: border-box;
     padding: 7px;
     margin: 0 7px 0 0;
     &#search {

diff --git a/app/javascript/custom/query_builder.js b/app/javascript/custom/query_builder.js
@@ -94,23 +94,17 @@ $(function () {
         switch (typeForField) {
             case 'boolean':
                 return replaceWithBooleanInput(valueField);
-                break;
             case 'number':
                 return replaceWithNumber(valueField);
-                break;
             case 'date':
                 return replaceWithDateInput(valueField);
-                break;
             case 'collection':
                 return replaceWithCollection(valueField, fieldName);
-                break;
             case 'autocomplete':
                 return replaceWithAutocomplete(valueField, fieldName);
-                break;
             case 'text':
             default:
                 return replaceWithTextInput(valueField);
-                break;
         }
     }
     $(document).on('change', '.operator', function() {