Dependency mismatch corrections #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The symmetric difference between versions of parsec and parsec-tool is computed using sets. The exception list has a specific order, so when checking whether the version differences between parsec and parsec-tool are allowed (are in the same as the ones in the exception list), this may appear to not be allowed. * Sort the exception lists and the list obtained from calculating the symmetric difference so that the comparison between them can be performed without ordering issues. Signed-off-by: Tomás González <[email protected]>
Dependencies that have more than one version should be checked for the case where only parsec-tool repo itself is being analyzed. For comparing between two repositories, we should be checking any mismatch between the two. Signed-off-by: Tomás González <[email protected]>
* Correct an obvious mistake on the parsec flags for cargo tree. * Change the exception list accordingly Signed-off-by: Tomás González <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When transferring the changes to Parsec as indicated in #116 , some issues were spotted. Correct those issues.