Include AES_CBC_ENCRYPT_DATA mechanism #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktor-k
reviewed
Jun 10, 2023
| @@ -0,0 +1,51 @@ | |||
| // Copyright 2021 Contributors to the Parsec project. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2021 Contributors to the Parsec project. | |
| // Copyright 2023 Contributors to the Parsec project. | |
| /// | ||
| /// # Panics | ||
| /// | ||
| /// This function panics if the lenght of `data` does not |
There was a problem hiding this comment.
Suggested change
| /// This function panics if the lenght of `data` does not | |
| /// This function panics if the length of `data` does not | |
| pub fn data(&self) -> &[u8] { | ||
| unsafe { std::slice::from_raw_parts(self.inner.pData, self.inner.length as _) } | ||
| } | ||
| } |
There was a problem hiding this comment.
I think a newline here would be nice.
| inner: CK_AES_CBC_ENCRYPT_DATA_PARAMS, | ||
| _marker: PhantomData<&'a [u8]>, | ||
| } | ||
| impl<'a> AesCBCEncryptDataParams<'a> { |
There was a problem hiding this comment.
nit: line spacing may be good :)
|
Apparently this is already implemented through #178. Closing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed AES_CBC_ENCRYPT_DATA and it's param structure AES_CBC_ENCRYPT_DATA_PARAMS were not included in the Mechanism enum.
Using other implementation codebase, i managed to include it.
I tested it using SoftHSM2.