Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for 32bit arch #193

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

ionut-arm
Copy link
Member

The value we use in the token info debug test overflows on 32bit architectures and makes the test fail. This fixes the issue by making the overflowing value < 2^32.

Fixes #186

The value we use in the token info debug test overflows on 32bit
architectures and makes the test fail. This fixes the issue by making
the overflowing value < 2^32.

Signed-off-by: Ionut Mihalcea <[email protected]>
Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Too bad that GitHub doesn't have any 32-bit runners so we could add a test job but... it's good that the community is catching all these weird edge cases :)

Copy link
Contributor

@gowthamsk-arm gowthamsk-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@gowthamsk-arm gowthamsk-arm merged commit 7d8252e into parallaxsecond:main Dec 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test slot::token_info::test::debug_info fails on 32-bit architectures.
3 participants