Session.find_objects(): implement fewer calls to C_FindObjects() #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Devolder <[email protected]>
keldonin
force-pushed
the
implement_fewer_C_FindObjects_iterations
branch
from
6cbd0b1
to
2676100
Compare
Signed-off-by: Eric Devolder <[email protected]>
hug-dev
previously approved these changes
Aug 28, 2024
Signed-off-by: Eric Devolder <[email protected]>
hug-dev
reviewed
Aug 28, 2024
Signed-off-by: Eric Devolder <[email protected]>
hug-dev
approved these changes
Aug 30, 2024
wiktor-k
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains code that optimizes
Session.find_objects(). It essentially quit the loop as soon as less thanMAX_OBJECT_COUNThave been returned byC_FindObjects().It typically results in calling one less time the underlying API
C_FindObjects().Testing code included.