Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust code to compile under rust 1.80 #217

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Adjust code to compile under rust 1.80 #217

merged 2 commits into from
Aug 30, 2024

Conversation

keldonin
Copy link
Collaborator

fix for issue #216

@keldonin
Copy link
Collaborator Author

CI scripts fail, but for another reason this time. Can the project maintainer check out what's going on? The errors are about sections that have not been changed by this PR (indentation on comments)

@gowthamsk-arm
Copy link
Contributor

Fixed in #218

@keldonin
Copy link
Collaborator Author

It seems like #217 and #218 are both needed together to go address this problem. I therefore combined changes from #218 into this PR, as #217 won't work alone, for the reasons #218 was created.
Hopefully this should make its way through the CI this time.

@keldonin keldonin mentioned this pull request Aug 29, 2024
Closed
gowthamsk-arm
gowthamsk-arm approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@gowthamsk-arm gowthamsk-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ionut-arm
ionut-arm approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gowthamsk-arm gowthamsk-arm merged commit a756363 into parallaxsecond:main Aug 30, 2024
7 checks passed
@keldonin keldonin deleted the fix_rust_toolchain_1_80_compilation_issues branch September 2, 2024 15:24
@keldonin keldonin mentioned this pull request Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ionut-arm ionut-arm ionut-arm approved these changes

@gowthamsk-arm gowthamsk-arm gowthamsk-arm approved these changes

@tgonzalezorlandoarm tgonzalezorlandoarm Awaiting requested review from tgonzalezorlandoarm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keldonin @gowthamsk-arm @ionut-arm